Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=919590 Kevin Fenzi <kevin@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+ --- Comment #3 from Kevin Fenzi <kevin@xxxxxxxxx> --- OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (MIT) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: d8de06a543989b910e46d2793f96fb9c5cbd7f99ab014982945b58ae60289893 tftpy-0.6.0.tar.gz d8de06a543989b910e46d2793f96fb9c5cbd7f99ab014982945b58ae60289893 tftpy-0.6.0.tar.gz.orig OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package is code or permissible content. OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) See below - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have dist tag OK - Should package latest version OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin Issues: 1. rpmlint says: python-tftpy.noarch: W: spelling-error %description -l en_US tsize -> size, t size python-tftpy.noarch: W: no-manual-page-for-binary tftpy_client.py python-tftpy.noarch: W: no-manual-page-for-binary tftpy_server.py python-tftpy.src: W: spelling-error %description -l en_US tsize -> size, t size 2 packages and 0 specfiles checked; 0 errors, 4 warnings. All those can be ignored. I don't see any bockers here, so this package is APPROVED. Let me go ahead and review your other two and see about sponsoring you after those are done. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=CSNTBCyRzX&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review