Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: avrdude -Software for programming Atmel AVR Microcontroller https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230324 ------- Additional Comments From trond.danielsen@xxxxxxxxx 2007-02-28 07:52 EST ------- (In reply to comment #2) > MUST fix: > ========= > * Doesn't compile, this can be fixed by removing "%{?_smp_mflags}" from the > make command. Note that you can usually reproduce this problem yourself by > adding "%_smp_mflags -j3" to ~/.rpmmacros . I have this even though I'm on a > uni-processor machine. I did get this message if I did not remove the build tree before rebuilding, but otherwise I could not reproduce the error, and I already had "%_smp_mflags -j3" in ~/.rpmmacros. However, I removed _smp_mflags from make, and it works just fine now. > * Missing BuildRequires: ncurses-devel readline-devel. Note that ncurses-devel > is not really needed as readline-devel already Requires it. I did not have any problems when building the package in mock, but I added the requirements anyway. > * This rpmlint message: > W: avrdude-debuginfo spurious-executable-perm > /usr/src/debug/avrdude-5.3.1/safemode.c > Just chmod -x the file in %prep FIXED. (in Reply to comment #3) > (In reply to comment #2) > > * Can you explain a bit about how the config file is not supposed to > > be modified by end-users? > I doubt Trond's statement. It's a system-wide configuration file, being > generated by the configure script, not a sample. > IMO, if it's a sample then it must not be located under /etc but should be > placed elsewhere (e.g. %doc) > > For the moment I'd recommend to use > %configure ... --sysconfdir=%{_sysconfdir}/avrdude > And to mark it %config(noreplace) > > i.e. to treat it as a system-wide config file. avrdude.conf is a system-wide config file - and not just a sample file - and is usually not edited by the users. But I added the (noreplace) parameter to %config just in case, and moved avrdude.conf to a separate folder under /etc, as suggested. The reason for not adding noreplace initially, was just my misunderstanding of what noreplace did, but http://fedora.redhat.com/docs/drafts/rpm-guide-en/ch09s05.html#id2972655 enlightened me :) I uploaded the new versions to the same location. No errors from rpmlint no any of the packages. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review