[Bug 880880] Review Request: php-scssphp - A compiler for SCSS written in PHP

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=880880

--- Comment #5 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> ---
About removing php-common in my previous comment.

>From Guidelines, you must requires all need extensions (so not the package
which provides an extension). php-common is only used for version check.

In your previous spec, requiring php-common without any version have no sense,
the reason why I ask to remove it.

As in this new spec, you require a minimal version, you have to do the check on
php-common (or better, on php(language) which is now available on EL-6)

As the shebang is now correct, the package have a auto detected dep on
/usr/bin/php, so you don't need to require php-cli.

About %{__php}, this macro is only defined:
- on Fedora
- with php-devel installed

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=pG240RYYsA&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]