[Bug 914988] Review Request: php-SymfonyCmfRouting - Extends the Symfony2 routing component for dynamic routes and chaining several routers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=914988

--- Comment #7 from Shawn Iwinski <shawn.iwinski@xxxxxxxxx> ---
Spec changes:
https://github.com/siwinski/rpms/commit/82aa35baf46e661917cf1b01c44c5bc84883fb98


SPEC URL:
http://siwinski.fedorapeople.org/rpmbuild/SPECS/php-SymfonyCmfRouting.spec

SRPM URL:
http://siwinski.fedorapeople.org/rpmbuild/SRPMS/php-SymfonyCmfRouting-1.0.0-0.3.alpha4.20130306git4706313.fc18.src.rpm



(In reply to comment #6)
> [!]: Rpmlint is run on all rpms the build produces.
> 	php-SymfonyCmfRouting.noarch: E: summary-too-long C Extends the Symfony2
> routing component for dynamic routes and chaining several routers

Fixed


> [!]: Package is named according to the Package Naming Guidelines.
> 	same comment about github snapshot.
> 	https://github.com/symfony-cmf/Routing/archive/1.0.0-alpha4.tar.gz
> 	Release: 0.2.alpha4%{dist} is enough (date + rev don't make sense here)

I agree I should have used just "0.2.alpha4%{dist}" when packaging the exact
tagged version.  However, I just updated the package to the latest snapshot
because of Symfony 2.2 fixes -- additional commits beyond the 1.0.0-alpha4
version.


> [!]: All build dependencies are listed in BuildRequires, except for any that
> 	BuildRequires: php-PsrLog
> 	BuildRequires: php-pear(pear.symfony.com/Routing)
> 	BuildRequires: php-pear(pear.symfony.com/HttpKernel)

Fixed Symfony build requires, however, see note below regarding PSR Log
package.


> [!]: %check is present and all tests pass.
> 	Local build (with symfony installed)
> 		Fatal error: Interface 'Psr\Log\LoggerInterface' not found
> 	Mock build
> 		3 skipped tests
> 
> [!]: Requires correct, justified where necessary.
> 	According to recent discussion on -devel 2 requires seems ok.
> 
> 	Probably need (else please justify)
> 	Requires: php-PsrLog

I believe you are seeing this error because of your local HttpKernel 2.2
package [1] not requiring it's new PSR Log dependency [2].  Koji scratch build
(which currently has Symfony 2.1 versions) build successfully [3].

[1] I'm assuming
https://github.com/remicollet/remirepo/blob/master/php/symfony2/php-symfony2-HttpKernel/php-symfony2-HttpKernel.spec

[2] https://github.com/symfony/HttpKernel/blob/v2.2.0/composer.json#L22

[3] http://koji.fedoraproject.org/koji/taskinfo?taskID=5100062

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=QriVCqGO6t&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]