[Bug 916405] Review Request: php-Assetic - Asset Management for PHP

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=916405

Remi Collet <fedora@xxxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review?

--- Comment #7 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> ---
No blocker, but

[!]: Latest version is packaged.
    1.0.4 is tagged.

Why do you take a github snapshot, when upstream properly tag each release and
provides a tarball ?

>From guidelines https://fedoraproject.org/wiki/Packaging:SourceURL#Github
    "If the upstream does create tarballs you should use them as tarballs
    provide an easier trail for people auditing the packages."

Ex : https://github.com/kriswallsmith/assetic/archive/v1.1.0-alpha4.tar.gz

[!]: Requires correct, justified where necessary.
    Where do you find info about the twig / symfony min / max version ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1bBYQOvTJO&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]