Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=919044 --- Comment #22 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- thanks Michael. :) I may as well start a formal review. 1. SHOULD saying License: GPLv2 here is justifiable too, given the About box text. It's not *wrong*, I just consider GPLv2+ to be more accurate. Ideally, could you contact your upstream and ask them for clarification? $ rpmlint *.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. 2. SHOULD: add -DCMAKE_BUILD_TYPE=Release back , the %cmake macro doesn't set this. not setting this means you miss out on: add_definitions(-DNDEBUG) add_definitions(-DQT_NO_DEBUG_OUTPUT) 3. SHOULD remove deprecated items in .spec like Group: tag, and in %install %{__rm} -rf %{buildroot} (rpm does this by default now, for awhile) 4. SHOULD remove %description references "working in Linux and Windows.". This package is build on/for fedora (linux), so that's just extraneous. scriptlets: ok (none) macro usage: ok (especially if item 3 is implemented, otherwise you have a mixture of using 'rm' and '%{__rm}' in different places) sources: ok 21bffd96f8c9f68fb3ad04dfa76d249f screengrab-0.9.1.tar.gz .desktop validation: ok 5. MUST: address bundled libraries, try to use system copy of qxt instead. If you need help implementing this, I can take a closer look. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=o7qpRF2Jrp&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review