Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912106 --- Comment #2 from Jamie Nguyen <jamielinux@xxxxxxxxxxxxxxxxx> --- > The license text should really be included with the distributed code > as it is a requirement of both licenses. Certainly we need to add a > copy until upstream includes it. Done. > There is a 2.1.5 release upstream now. Updated. > It's not clear to me that installing r.js in %{_bindir} is appropriate > or necessary - it doesn't seem to me from the web site that people are > intended to run it from the command line? As shipped it isn't > executable and running it just tells you to look at the web site. Totally agree. I've removed r.js from %{_bindir}. (This happened out of habit rather than a deliberate decision to put it in %{_bindir}.) Spec URL: http://jamielinux.fedorapeople.org/jasmine-node/nodejs-requirejs.spec SRPM URL: http://jamielinux.fedorapeople.org/jasmine-node/SRPMS/nodejs-requirejs-2.1.5-1.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=EFX7IM3Fny&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review