Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=916087 Sandro Mathys <sm@xxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: |Review Request: |cloud-initramfs - cloud |cloud-initramfs-tools - |image initramfs management |cloud image initramfs |utilities |management utilities --- Comment #16 from Sandro Mathys <sm@xxxxxxxxxxxxxxxx> --- Personally, I would use /usr/lib and %{_datadir} instead of %{_prefix}/lib and %{_prefix}/share, but I don't think there's hard rules for either which makes it simply a matter of taste. Also, you're writing "bzr85" a lot, I'd recommend to define something like "%global rev 85" at the very top and use "bzr%{rev}" everywhere else instead. Will save you some editing when updating the package in the future. Anyway, looks good to me from a strictly technical point of view but I haven't done a formal review as I understand Matthew will do that. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=pFf1xhZuVM&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review