Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: grub2 - grub next generation tools https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=228255 cr33dog@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cr33dog@xxxxxxxxx ------- Additional Comments From cr33dog@xxxxxxxxx 2007-02-28 00:12 EST ------- I have not performed many reviews, so I may miss things. It appears that you need a sponsor - I will be unable to sponsor you. If you haven't yet, look here for more info: http://fedoraproject.org/wiki/Extras/HowToGetSponsored *Source0 should contain the full URL *Is there a reason for the duplicate Patch1 and Patch2 and the commented lines in the %prep section? *rpmlint output: W: grub2 summary-ended-with-dot GRUB 2 - the Grub Unified Boot Loader. W: grub2 non-standard-group System Enviroment/Base W: grub2 setup-not-quiet W: grub2 patch-not-applied Patch2: grub2-program-name-tranform-i386-pc.patch *add "%{?dist}" to Version if this is going in more than one branch. *can you use "make DESTDIR=%{buildroot} install" or "make DESTDIR=$RPM_BUILD_ROOT install" instead of %makeinstall? (see: http://fedoraproject.org/wiki/Packaging/Guidelines#head-fcaf3e6fcbd51194a5d0dbcfbdd2fcb7791dd002) Building in mock hasn't completed yet - I'll post the result in the morning. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review