Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=919044 --- Comment #12 from Kevin Kofler <kevin@xxxxxxxxxxxxxxxx> --- In particular, src/3rdparty/qxt is from http://pkgs.fedoraproject.org/cgit/libqxt.git/ and should use the system libqxt package. Some of the stuff in src/common is also being built as a library for some reason, even though it is from the same author (and therefore it can probably stay bundled). The stuff in src/common/singleapp is different from qtsingleapplication which we have in Fedora. It's quite sad to have 3 implementations of essentially the same thing (kdelibs also has one), but that's not our problem. CMake itself defaults to building libraries static, our %cmake macro defaults to building them shared. So if you want those libraries to be static (because you don't want to install headers and provide -devel and -libs packages allowing their use with other packages, because they're internal to the application) and/or if they don't compile at all as shared (e.g. due to symbol visibility issues), add an explicit STATIC to the relevant add_library lines in the relevant CMakeLists.txt files and send that patch upstream. (You can also add -DBUILD_SHARED_LIBS:BOOL=OFF to the %cmake line instead, but CMakeLists.txt files really shouldn't assume that the default is static: add_library with nothing specified only makes sense where it makes sense to build the library as either static or shared at the user's request (BUILD_SHARED_LIBS).) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=f11pBOnl4v&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review