Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=907261 --- Comment #4 from Alejandro Alvarez <alejandro.alvarez.ayllon@xxxxxxx> --- Hi, [OK] Preserve AUTHORS timestamp [OK] Use %%{optflags} [--] Add a comment about Makefile I would still put the Makefile somewhere reachable (the same Github area where you put the spec, perhaps?) [OK] Added doc to -devel package Not sure how critical the Makefile part is, but, for the rest, it looks good to me. (In reply to comment #3) > (In reply to comment #2) > > [FAIL] The sources used to build the package must match the upstream source, > > as provided in the spec URL. > > > > The .spec file instructions for retrieving upstream do not match the > > revision used for the given srpm > > (it is just missing the specific revision as a parameter) > Do you have any idea, how to do this in mercurial? > The instructions in spec currently match the latest revision, acf81f1f1764 > right now, but could change later. I think: hg clone --rev REVISION %%{url} > Thank you. Please assign this bug to you and set the fedora-review flag. Sorry, but I have just joined as co-maintainer of existing packages, so I am still "on probation". I shouldn't do formal reviews yet. Regards. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qbfTqnSGrF&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review