Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=906482 --- Comment #2 from Peter Lemenkov <lemenkov@xxxxxxxxx> --- Hello! (In reply to comment #1) > Hi, > > the main issue here is with the license I think. > On the upstream github pages there is no clear info what license applies (at > least I could not find it). > There is an open pull request to add the BSD license, but this has not been > merged into the main branch, so it is not obvious to me that this applies. > Could you verify with upstream what the license status is? Yes, I'm working on it. I've just contacted upstream developer directly - let's wait for his answer. > A few other small issues here: > -the rebar executable is part of the source package. To make sure the proper > fedora copy in /usr/bin/rebar from the erlang-rebar package is used, I think > it is best to delete the rebar copy delivered in this package before > starting the build. Good point. I'll add this with the licensing. > -the install command probably should get the '-p' option to ensure > modification times of the files are preserved. > (see https://fedoraproject.org/wiki/Packaging:Guidelines > in the Timestamps section) Likewise - that's for the pointing me out on this. I'll add this as soon as the licensing issue will be resolved. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=RgdLJOx4cw&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review