[Bug 912930] Review Request : icaro - Robotic Educational Project

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=912930

--- Comment #3 from Matthias Runge <mrunge@xxxxxxxxxx> ---
Ooops, sorry, this took so long.

Eduardo, please move header files to a sub package:
- Header files in -devel subpackage, if present.
  Note: icaro : /usr/share/icaro/pic16/np05/source/boot_iface.h icaro :
  /usr/share/icaro/pic16/np05/source/common_types.h icaro :
  /usr/share/icaro/pic16/np05/source/define.h icaro :
  /usr/share/icaro/pic16/np05/source/macro.h icaro :
  /usr/share/icaro/pic16/np05/source/usb/picUSB.h icaro :
  /usr/share/icaro/pic16/np05/source/usb/usb_bulk.h icaro :
  /usr/share/icaro/pic16/np05/source/usb/usb_cdc.h icaro :
  /usr/share/icaro/pic16/np05/source/usb/usb_config.h icaro :
  /usr/share/icaro/pic16/np05/source/usb/usb_uart.h
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages
- update-desktop-database is invoked when required
  Note: desktop file(s) in icaro
  See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache


- is there any particular reason not to use the %find_lang macro?
- since you're using /usr/share/icons/hicolor/48x48, you need to require
something providing that path, e.g. hicolor-icon-theme (please check status of
that, I think it was recently orphaned)


and we have a mixture of licenses here: 
LGPL (v2.1 or later)
--------------------
/var/lib/mock/fedora-rawhide-x86_64/root/builddir/build/BUILD/icaro-55e2c11a61810477a60f4a162072db92dcfd13d8/pic16/np05/source/servos.c

*No copyright* GPL (v3 or later)
--------------------------------
/var/lib/mock/fedora-rawhide-x86_64/root/builddir/build/BUILD/icaro-55e2c11a61810477a60f4a162072db92dcfd13d8/componente.py

GPL (v2 or later)
-----------------
/var/lib/mock/fedora-rawhide-x86_64/root/builddir/build/BUILD/icaro-55e2c11a61810477a60f4a162072db92dcfd13d8/docker.py

GPL (v3 or later)
-----------------
/var/lib/mock/fedora-rawhide-x86_64/root/builddir/build/BUILD/icaro-55e2c11a61810477a60f4a162072db92dcfd13d8/creditos.py

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6PREpmTCdB&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]