Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: zsh https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226813 kevin@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|needinfo?(james.antill@redha| |t.com) | ------- Additional Comments From kevin@xxxxxxxxx 2007-02-27 19:25 EST ------- 1. The buildroot you are using is the one that didn't get approved a few weeks ago. Hopefully however this will all be moot soon, as their is a proposal up to make buildroot back to a reccomendation with several acceptable prefered values. 2. rpmlint on this version says: E: zsh non-executable-script /usr/share/zsh/4.2.6/functions/checkmail 0644 E: zsh non-executable-script /usr/share/zsh/4.2.6/functions/checkmaile 0644 E: zsh non-executable-script /usr/share/zsh/4.2.6/functions/harden 0644 E: zsh non-executable-script /usr/share/zsh/4.2.6/functions/hardene 0644 E: zsh non-executable-script /usr/share/zsh/4.2.6/functions/run-help 0644 E: zsh non-executable-script /usr/share/zsh/4.2.6/functions/run-helpe 0644 E: zsh non-executable-script /usr/share/zsh/4.2.6/functions/zcalc 0644 E: zsh non-executable-script /usr/share/zsh/4.2.6/functions/zcalce 0644 E: zsh non-executable-script /usr/share/zsh/4.2.6/functions/zkbd 0644 E: zsh non-executable-script /usr/share/zsh/4.2.6/functions/zkbde 0644 Your 'sed -ie' should be 'sed -i' ? (it's creating the e ending files) Also, those should be mode 755? Since they look like executable scripts? E: zsh use-of-RPM_SOURCE_DIR Would be nice to fix this... E: zsh use-tmp-in-%postun Not sure what this is about... E: zsh wrong-script-interpreter /usr/share/zsh/4.2.6/functions/checkmaile "/usr/local/bin/zsh" E: zsh wrong-script-interpreter /usr/share/zsh/4.2.6/functions/run-helpe "/usr/local/bin/zsh" E: zsh wrong-script-interpreter /usr/share/zsh/4.2.6/functions/zcalce "/usr/local/bin/zsh" The sed -ie issue. ;) W: zsh dangerous-command-in-%postun chown Not sure how else to do that... W: zsh hidden-file-or-dir /etc/skel/. W: zsh hidden-file-or-dir /etc/skel/. W: zsh hidden-file-or-dir /etc/skel/.. W: zsh hidden-file-or-dir /etc/skel/.. W: zsh hidden-file-or-dir /etc/skel/../skel/.zshrc W: zsh hidden-file-or-dir /etc/skel/.zshrc W: zsh hidden-file-or-dir /etc/skel/./.zshrc Your "%config(noreplace) %{_sysconfdir}/skel/.*" doesn't seem right. How about "%config(noreplace) %{_sysconfdir}/skel/.zshrc" ? W: zsh mixed-use-of-spaces-and-tabs (spaces: line 71, tab: line 107) Still might be nice to fix. W: zsh patch-not-applied Patch1: zsh-4.0.6-make-test-fail.patch Might be nice to remove. W: zsh prereq-use fileutils grep /sbin/install-info The use of PreReq is deprecated. In the majority of cases, a plain Requires is enough and the right thing to do. Sometimes Requires(pre), Requires(post), Requires(preun) and/or Requires(postun) can also be used instead of PreReq. I think in this case you can ignore fileutils and grep, but install-info will need to have Requires(post) and Requires(preun). See: http://www.fedoraproject.org/wiki/Packaging/ScriptletSnippets?action=show&redirect=ScriptletSnippets#head-47896da5fb2662d75deefeb9ba75145a398515db for more info. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review