Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912834 --- Comment #9 from Gregor Tätzner <gregor@xxxxxxxxxx> --- Spec URL: http://brummbq.fedorapeople.org/php-dropbox-php-Dropbox.spec SRPM URL: http://brummbq.fedorapeople.org/php-dropbox-php-Dropbox-1.0.0-3.fc17.src.rpm (In reply to comment #7) > > * MUST: Please change source to: "http://%{channelname}/get/%{pear_name}-% > {version}.tgz". Remote source through the actual PEAR host. cool, no need to fiddle around with github > * MUST: Do not move PEAR documentation. It may stay in place in > pear_docdir, and just marked as %doc in %files (i.e. "%doc > %{pear_docdir}/%{pear_name}") I was using the template from rpmdev-newspec, probably that should be updated > > * COULD: Include a note about optional dependency HTTP_OAuth (package name > php-pear-HTTP-OAuth) in %description, or even include it as a dependency > ("Require: php-pear(HTTP_OAuth)") if you think most users will benefit from > it being installed for you package. added to Requires (In reply to comment #8) > Please work with upstream to get the tests added to the PEAR package itself > (and make sure they are marked with role="test"). When they are available > in the PEAR pkg source, the tests must be run in %check -- although note > that you may need make updates to not rely on any remote connections for > tests. Since the tests are not available in the PEAR package right now > though, no need to worry about them. Will do, but I worry upstream is not that active any more. and thanks for the help! -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qWxmMq9iLH&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review