Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=895667 Paulo Andrade <paulo.cesar.pereira.de.andrade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? --- Comment #12 from Paulo Andrade <paulo.cesar.pereira.de.andrade@xxxxxxxxx> --- Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Spec file lacks Packager, Vendor, PreReq tags. Note: Found : Packager: pcpa <paulo.cesar.pereira.de.andrade@xxxxxxxxx> See: (this test has no URL) ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [x]: Sources contain only permissible code or content. [x]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [x]: Package complies to the Packaging Guidelines [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD (3 clause)", "BSD (2 clause)", "GPL (v2 or later)", "Unknown or generated". 4 files have unknown license. Detailed output of licensecheck in /home/pcpa/895667-polymake/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package consistently uses macro is (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Large documentation must go in a -doc subpackage. Note: Documentation size is 30720 bytes in 1 files. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Fully versioned dependency in subpackages, if present. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). Perl: [x]: Package contains the mandatory BuildRequires and Requires:. ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Scriptlets must be sane, if used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [?]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [?]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 5191680 bytes in /usr/share 2938880 polymake-doc-2.12-4.fc19.x86_64.rpm 2242560 polymake-2.12-4.fc19.x86_64.rpm 10240 polymake- devel-2.12-4.fc19.x86_64.rpm [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: polymake-2.12-4.fc19.x86_64.rpm polymake-devel-2.12-4.fc19.x86_64.rpm polymake-doc-2.12-4.fc19.x86_64.rpm polymake.x86_64: W: spelling-error Summary(en_US) polytopes -> polytheist polymake.x86_64: W: spelling-error Summary(en_US) polyhedra -> polyhedral, polyhedron polymake.x86_64: W: spelling-error %description -l en_US combinatorics -> combinations polymake.x86_64: W: spelling-error %description -l en_US polytopes -> polytheist polymake.x86_64: W: spelling-error %description -l en_US polyhedra -> polyhedral, polyhedron polymake.x86_64: W: spelling-error %description -l en_US simplicial -> simplicity, simplistic polymake.x86_64: W: spelling-error %description -l en_US matroids -> mastoids polymake.x86_64: W: spelling-error %description -l en_US azove -> above, Azov polymake.x86_64: W: spelling-error %description -l en_US gfan -> fan, fang, gran polymake.x86_64: W: spelling-error %description -l en_US integrale -> integral, integrals, integrate polymake.x86_64: W: spelling-error %description -l en_US normaliz -> normalize, normalization, normal polymake.x86_64: W: spelling-error %description -l en_US ocaml -> Occam polymake.x86_64: W: spelling-error %description -l en_US tplib -> split polymake.x86_64: W: spelling-error %description -l en_US qhull -> hull, q hull, Hull polymake.x86_64: W: spelling-error %description -l en_US vinci -> vincible polymake.x86_64: W: spelling-error %description -l en_US geomview -> geom view, geom-view, overview polymake.x86_64: W: spelling-error %description -l en_US graphviz -> graph viz, graph-viz, graphic polymake.x86_64: W: spelling-error %description -l en_US gv -> g, v, gov polymake.x86_64: W: spelling-error %description -l en_US okular -> ocular, ovular polymake.x86_64: W: no-soname /usr/lib64/polymake/lib/core.so polymake.x86_64: W: no-soname /usr/lib64/polymake/lib/matroid.so polymake.x86_64: W: no-soname /usr/lib64/polymake/lib/tropical.so polymake.x86_64: W: no-soname /usr/lib64/polymake/lib/graph.so polymake.x86_64: W: no-soname /usr/lib64/polymake/lib/common.so polymake.x86_64: W: no-soname /usr/lib64/polymake/lib/topaz.so polymake.x86_64: W: no-soname /usr/lib64/polymake/lib/polytope.so polymake.x86_64: W: no-soname /usr/lib64/polymake/lib/group.so polymake.x86_64: W: no-soname /usr/lib64/polymake/lib/fan.so polymake-devel.x86_64: W: no-documentation polymake-devel.x86_64: W: no-manual-page-for-binary polymake-config 3 packages and 0 specfiles checked; 0 errors, 30 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint polymake-doc polymake polymake-devel polymake.x86_64: W: spelling-error Summary(en_US) polytopes -> polytheist polymake.x86_64: W: spelling-error Summary(en_US) polyhedra -> polyhedral, polyhedron polymake.x86_64: W: spelling-error %description -l en_US combinatorics -> combinations polymake.x86_64: W: spelling-error %description -l en_US polytopes -> polytheist polymake.x86_64: W: spelling-error %description -l en_US polyhedra -> polyhedral, polyhedron polymake.x86_64: W: spelling-error %description -l en_US simplicial -> simplicity, simplistic polymake.x86_64: W: spelling-error %description -l en_US matroids -> mastoids polymake.x86_64: W: spelling-error %description -l en_US azove -> above, Azov polymake.x86_64: W: spelling-error %description -l en_US gfan -> fan, fang, gran polymake.x86_64: W: spelling-error %description -l en_US integrale -> integral, integrals, integrate polymake.x86_64: W: spelling-error %description -l en_US normaliz -> normalize, normalization, normal polymake.x86_64: W: spelling-error %description -l en_US ocaml -> Occam polymake.x86_64: W: spelling-error %description -l en_US tplib -> split polymake.x86_64: W: spelling-error %description -l en_US qhull -> hull, q hull, Hull polymake.x86_64: W: spelling-error %description -l en_US vinci -> vincible polymake.x86_64: W: spelling-error %description -l en_US geomview -> geom view, geom-view, overview polymake.x86_64: W: spelling-error %description -l en_US graphviz -> graph viz, graph-viz, graphic polymake.x86_64: W: spelling-error %description -l en_US gv -> g, v, gov polymake.x86_64: W: spelling-error %description -l en_US okular -> ocular, ovular polymake.x86_64: W: no-soname /usr/lib64/polymake/lib/core.so polymake.x86_64: W: no-soname /usr/lib64/polymake/lib/matroid.so polymake.x86_64: W: no-soname /usr/lib64/polymake/lib/tropical.so polymake.x86_64: W: no-soname /usr/lib64/polymake/lib/graph.so polymake.x86_64: W: no-soname /usr/lib64/polymake/lib/common.so polymake.x86_64: W: no-soname /usr/lib64/polymake/lib/topaz.so polymake.x86_64: W: undefined-non-weak-symbol /usr/lib64/polymake/lib/topaz.so polymake::graph::BlissGraph::alloc_impl(int, bool) polymake.x86_64: W: undefined-non-weak-symbol /usr/lib64/polymake/lib/topaz.so polymake::graph::BlissGraph::operator==(polymake::graph::BlissGraph const&) const polymake.x86_64: W: undefined-non-weak-symbol /usr/lib64/polymake/lib/topaz.so polymake::graph::find_vertex_node(polymake::graph::HasseDiagram const&, int) polymake.x86_64: W: undefined-non-weak-symbol /usr/lib64/polymake/lib/topaz.so polymake::graph::HasseDiagram::makeObject() const polymake.x86_64: W: undefined-non-weak-symbol /usr/lib64/polymake/lib/topaz.so polymake::graph::BlissGraph::~BlissGraph() polymake.x86_64: W: undefined-non-weak-symbol /usr/lib64/polymake/lib/topaz.so polymake::graph::BlissGraph::add_edge(unsigned int, unsigned int) polymake.x86_64: W: undefined-non-weak-symbol /usr/lib64/polymake/lib/topaz.so polymake::graph::operator>>(pm::perl::Value const&, polymake::graph::HasseDiagram&) polymake.x86_64: W: undefined-non-weak-symbol /usr/lib64/polymake/lib/topaz.so polymake::graph::BlissGraph::partition(unsigned int) polymake.x86_64: W: undefined-non-weak-symbol /usr/lib64/polymake/lib/topaz.so polymake::graph::HasseDiagram::delete_node(int) polymake.x86_64: W: undefined-non-weak-symbol /usr/lib64/polymake/lib/topaz.so polymake::graph::BlissGraph::finalize(bool) polymake.x86_64: W: undefined-non-weak-symbol /usr/lib64/polymake/lib/topaz.so polymake::graph::BlissGraph::find_permutations(polymake::graph::BlissGraph const&, int) const polymake.x86_64: W: undefined-non-weak-symbol /usr/lib64/polymake/lib/topaz.so polymake::graph::HasseDiagram::fromObject(pm::perl::Object const&) polymake.x86_64: W: no-soname /usr/lib64/polymake/lib/polytope.so polymake.x86_64: W: undefined-non-weak-symbol /usr/lib64/polymake/lib/polytope.so polymake::group::correct_group_from_permlib_group(pm::perl::Object, polymake::group::PermlibGroup const&) polymake.x86_64: W: undefined-non-weak-symbol /usr/lib64/polymake/lib/polytope.so polymake::group::group_from_perlgroup(pm::perl::Object) polymake.x86_64: W: undefined-non-weak-symbol /usr/lib64/polymake/lib/polytope.so polymake::graph::BlissGraph::find_permutations(polymake::graph::BlissGraph const&, int) const polymake.x86_64: W: undefined-non-weak-symbol /usr/lib64/polymake/lib/polytope.so polymake::graph::BlissGraph::color(unsigned int, unsigned int) polymake.x86_64: W: undefined-non-weak-symbol /usr/lib64/polymake/lib/polytope.so polymake::graph::operator>>(pm::perl::Value const&, polymake::graph::HasseDiagram&) polymake.x86_64: W: undefined-non-weak-symbol /usr/lib64/polymake/lib/polytope.so polymake::graph::BlissGraph::add_edge(unsigned int, unsigned int) polymake.x86_64: W: undefined-non-weak-symbol /usr/lib64/polymake/lib/polytope.so polymake::graph::BlissGraph::finalize(bool) polymake.x86_64: W: undefined-non-weak-symbol /usr/lib64/polymake/lib/polytope.so polymake::graph::BlissGraph::operator==(polymake::graph::BlissGraph const&) const polymake.x86_64: W: undefined-non-weak-symbol /usr/lib64/polymake/lib/polytope.so polymake::graph::HasseDiagram::makeObject() const polymake.x86_64: W: undefined-non-weak-symbol /usr/lib64/polymake/lib/polytope.so polymake::graph::BlissGraph::alloc_impl(int, bool) polymake.x86_64: W: undefined-non-weak-symbol /usr/lib64/polymake/lib/polytope.so polymake::graph::HasseDiagram::fromObject(pm::perl::Object const&) polymake.x86_64: W: undefined-non-weak-symbol /usr/lib64/polymake/lib/polytope.so polymake::graph::BlissGraph::partition(unsigned int) polymake.x86_64: W: undefined-non-weak-symbol /usr/lib64/polymake/lib/polytope.so polymake::graph::BlissGraph::~BlissGraph() polymake.x86_64: W: no-soname /usr/lib64/polymake/lib/group.so polymake.x86_64: W: no-soname /usr/lib64/polymake/lib/fan.so polymake.x86_64: W: undefined-non-weak-symbol /usr/lib64/polymake/lib/fan.so polymake::graph::HasseDiagram::makeObject() const polymake.x86_64: W: undefined-non-weak-symbol /usr/lib64/polymake/lib/fan.so polymake::graph::operator>>(pm::perl::Value const&, polymake::graph::HasseDiagram&) polymake-devel.x86_64: W: no-documentation polymake-devel.x86_64: W: no-manual-page-for-binary polymake-config 3 packages and 0 specfiles checked; 0 errors, 57 warnings. # echo 'rpmlint-done:' Requires -------- polymake-doc (rpmlib, GLIBC filtered): polymake(x86-64) polymake (rpmlib, GLIBC filtered): /sbin/ldconfig /usr/bin/perl libbliss.so.0()(64bit) libc.so.6()(64bit) libcdd.so.0()(64bit) libcddgmp.so.0()(64bit) libdl.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgmp.so.10()(64bit) liblrsgmp.so.4()(64bit) libm.so.6()(64bit) libmpfr.so.4()(64bit) libperl.so()(64bit) libpolymake.so.2()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.1)(64bit) libsympol.so.0.1()(64bit) libxml2.so.2()(64bit) libxml2.so.2(LIBXML2_2.4.30)(64bit) perl perl(:MODULE_COMPAT_5.16.2) perl(Carp) perl(Config) perl(Cwd) perl(DynaLoader) perl(Encode) perl(Errno) perl(Fcntl) perl(File::Path) perl(Getopt::Long) perl(IO::Handle) perl(IPC::Open3) perl(Math::Trig) perl(POSIX) perl(Socket) perl(Symbol) perl(Term::ReadLine) perl(XML::LibXML) perl(XML::SAX::Base) perl(XML::Writer) perl(integer) perl(lib) perl(overload) perl(re) perl(strict) perl(subs) perl(vars) rtld(GNU_HASH) polymake-devel (rpmlib, GLIBC filtered): /usr/bin/perl libpolymake.so.2()(64bit) perl(strict) polymake(x86-64) Provides -------- polymake-doc: polymake-doc polymake-doc(x86-64) polymake: libpolymake.so.2()(64bit) polymake polymake(x86-64) polymake-devel: polymake-devel polymake-devel(x86-64) Unversioned so-files -------------------- polymake: /usr/lib64/polymake/lib/common.so polymake: /usr/lib64/polymake/lib/core.so polymake: /usr/lib64/polymake/lib/fan.so polymake: /usr/lib64/polymake/lib/graph.so polymake: /usr/lib64/polymake/lib/group.so polymake: /usr/lib64/polymake/lib/matroid.so polymake: /usr/lib64/polymake/lib/polytope.so polymake: /usr/lib64/polymake/lib/topaz.so polymake: /usr/lib64/polymake/lib/tropical.so polymake: /usr/lib64/polymake/perlx/5.16.2/x86_64-linux-thread-multi/auto/Polymake/Ext/Ext.so MD5-sum check ------------- http://polymake.org/lib/exe/fetch.php/download/polymake-2.12-rc3.tar.bz2 : CHECKSUM(SHA256) this package : 354a5220009882c178d8d98ec8c16921eea284ed73ff7d36c5fee787aa3f4796 CHECKSUM(SHA256) upstream package : 354a5220009882c178d8d98ec8c16921eea284ed73ff7d36c5fee787aa3f4796 Generated by fedora-review 0.4.0 (660ce56) last change: 2013-01-29 Buildroot used: fedora-rawhide-x86_64 Command line :/usr/bin/fedora-review -v -b 895667 ---%<--- Minor cosmetic issue: [...] # do not use -rpath, and enable running the units tests on a non-svn checkout. Patch0: %{name}-fedora.patch [...] tests are not run, but you promised to make it run on the next release at #c9 :-) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=yhRqqSqP6M&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review