[Bug 892433] Review Request: perl-ParseUtil-Domain - Utility for parsing a domain name into its components

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=892433

--- Comment #5 from Mathieu Bridon <bochecha@xxxxxxxxxxxxxxxxx> ---
(In reply to comment #3)
> (In reply to comment #2)
> > http://bochecha.fedorapeople.org/packages/perl-ParseUtil-Domain-2.22-2.fc19.
> > noarch.rpm
> 
> Correct link:
> http://bochecha.fedorapeople.org/packages/perl-ParseUtil-Domain-2.22-2.fc19.
> src.rpm

Sorry about that.

(In reply to comment #4)
> Missing BRs:
> perl(base) from various sources
> perl(lib) from various sources
> perl(Moose) from t/lib/AsciiToggle.pm:3, t/lib/UnicodeToggle.pm:3
> perl(Test::Routine::Util) from t/parse_ascii_test_routine.t:9

Thanks, fixed.

> I suppose changing "tlds" to "TLDs" in the description would nice.

Agreed, fixed.

> perl_default_filter is not necessary here.

But does it cause any trouble?

If not, I'd rather keep it there, so that I don't forget to add it if it
eventually becomes necessary in the future.

After all, it is a very good thing to have for many Perl packages...

----

Spec URL: http://bochecha.fedorapeople.org/packages/perl-ParseUtil-Domain.spec
SRPM URL:
http://bochecha.fedorapeople.org/packages/perl-ParseUtil-Domain-2.22-3.fc19.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qJF3YqUNhj&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]