[Bug 914988] Review Request: php-SymfonyCmfRouting - Extends the Symfony2 routing component for dynamic routes and chaining several routers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=914988

--- Comment #2 from Shawn Iwinski <shawn.iwinski@xxxxxxxxx> ---
(In reply to comment #1)
> Same comment for
>   Requires: foo >= x
>   Requires: foo <  y
> Should use
>   Requires:  foo >= x
>   Conflicts: foo >= y
> 
> Can you please move test out of include_path ?

The reason why I kept the tests in the include path is because:
1) they were just classes that could be loaded with a common autoloader
2) they were only installed with the *-tests sub-package

Also, I ran into an issue with a package (Symfony's TwigBridge to be exact)
that required test classes from another package (Symfony's Form) to be in the
include path.


> Notice : probably you can even not ship the test units. (they are usefull
> during build, but I don't think our users will need them)

OK.  It was a little bit of a pain to sub-package tests.  I will just not
package them (but still run them in %check).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=M1vSeOVAzR&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]