[Bug 916665] Review Request: librepo - Repodata downloading library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=916665

--- Comment #1 from Michael Schwendt <mschwendt@xxxxxxxxx> ---
* Run rpmlint (or the more helpful rpmlint -i) on all rpms, i.e. src.rpm and
all built rpms. Ignore false positives (e.g. strange warnings about spelling
mistakes), but examine, fix or comment on valid errors/warnings.


> Version:        0.0.1
> Release:        1.git%{gitrev}%{?dist}

https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages


> License: GPLv2

That's odd, because several files in ./librepo claim GPLv2+.
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#.22or_later_version.22_licenses


> Source0:        librepo-%{gitrev}.tar.xz

https://fedoraproject.org/wiki/Packaging:SourceURL#Using_Revision_Control
https://fedoraproject.org/wiki/Packaging:SourceURL#Github


> %package devel
> Requires:       %{name} = %{version}-%{release}

https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package
(also applies to the python-librepo package base dependency)

> %package -n python-librepo
> Group:          Development/Langueages

Typo.


> %files devel
> %doc COPYING

https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Subpackage_Licensing


> %files -n python-librepo
> %{python_sitearch}/

https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DTAhxMJ9NS&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]