Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912834 --- Comment #7 from Shawn Iwinski <shawn.iwinski@xxxxxxxxx> --- Hi Gregor -- A few updates required: * MUST: pear_metadata. Please add "%{!?pear_metadir: %global pear_metadir %{pear_phpdir}}" to the top of your spec. Also, in %install, change your cleaning up of unnecessary files to "rm -rf %{buildroot}%{pear_metadir}/.??*". * MUST: Please change source to: "http://%{channelname}/get/%{pear_name}-% {version}.tgz". Remote source through the actual PEAR host. * MUST: Change "BuildRequires: php-pear >= 1:1.4.9-1.2" to "BuildRequires: php-pear(PEAR)". Always use the virtual provide. * MUST: "Requires: php-channel(%{channelname})". This is required so the pear commands work. * MUST: Remove "Provides: php-pear(%{pear_name}) = %{version}". Should only virtual provide "channel/pkg". * MUST: Please use "%{name}.xml" instead of "%{pear_name}.xml" * MUST: Do not move PEAR documentation. It may stay in place in pear_docdir, and just marked as %doc in %files (i.e. "%doc %{pear_docdir}/%{pear_name}") * COULD: After PEAR remote source, %prep could simply be: %prep %setup -q -c # package.xml is version 2.0 mv package.xml %{pear_name}-%{version}/%{name}.xml * COULD: Include a note about optional dependency HTTP_OAuth (package name php-pear-HTTP-OAuth) in %description, or even include it as a dependency ("Require: php-pear(HTTP_OAuth)") if you think most users will benefit from it being installed for you package. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=G8Gu6BWga4&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review