Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=918129 Fabian Affolter <mail@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mail@xxxxxxxxxxxxxxxxxx --- Comment #2 from Fabian Affolter <mail@xxxxxxxxxxxxxxxxxx> --- Just some quick comments: - License is GPLv2+. Source header says: "either version 2 of the License, or (at your option) any later version." - The 'Summary' should not have a period at the end. - There is no need for cleaning the buildroot on current Fedora releases. %clean section and %defattr are no longer needed. Only if your package will go to EPEL5. https://fedoraproject.org/wiki/Packaging:Guidelines#.25clean https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DvzKs2hui8&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review