[Bug 868266] Review Request: pyglet - A cross-platform windowing and multimedia library for Python

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=868266

--- Comment #3 from Jerry James <loganjerry@xxxxxxxxx> ---
FWIW, dos2unix isn't necessary anyway.  You're already using sed on all of the
source files, so you might as well make it do the extra work.  I replaced the
two lines in %prep starting with "find" with this:

# Get rid of hashbang lines. This is a library, it has no executable scripts.
# Also remove Windows newlines
find . -name '*.py' | xargs sed -i -e 's|#!/usr/bin/\(env \)\?python||;s/\r//'

and now fedora-review likes it.  I don't know that there is anything wrong with
the original; it is probably a bug in mock.  But this lets me move forward with
the review (and the dos2unix BR can be removed).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wZdrh7mvbW&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]