Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=889011 Vít Ondruch <vondruch@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+ --- Comment #9 from Vít Ondruch <vondruch@xxxxxxxxxx> --- (In reply to comment #8) > We introduced a man page in 0.1.0, so I had to add an additional copy > command to get it to work. If you have a cleaner way to do it, just let me > know. Otherwise, it gets the job done. I don't know any other better way. On the other hand, it'd be nice RFE for RubyGems upstream * Add Requires: ruby(abi) - I asked you to remove "Requires: ruby". Unfortunately, you removed ruby(abi) as well. However, this must stay. This is the only issue I see with this package currently, so I conditionally APPROVE the package. However, please note that there are approved new Ruby packaging guidelines for F19. According to them, you should replace the ruby(abi) with ruby(release) and you should replace a "gem install" command by %gem_install macro. It would be cool if you can update the package accordingly and build already in f19-ruby targed, where the rebuild for Ruby 2.0.0 is ongoing. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=BDtKyWaddN&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review