Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863795 --- Comment #9 from Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> --- MUST: rpmlint must be run on the source rpm and all binary rpms the build produces. The output should be posted in the review. $ rpmlint /var/lib/mock/fedora-rawhide-x86_64/result kadu-mime_tex.x86_64: I: enchant-dictionary-not-found pl kadu-mime_tex.x86_64: W: spelling-error %description -l en_US tex -> Tex, ex, text kadu-mime_tex.x86_64: W: spelling-error %description -l en_US mathematic -> mathematics, ma thematic, ma-thematic kadu-mime_tex.x86_64: W: no-documentation kadu-messagessplitter.x86_64: W: no-documentation kadu-panelkadu.x86_64: W: no-documentation kadu-senthistory.x86_64: W: no-documentation kadu-networkping.x86_64: W: no-documentation kadu-import_history.x86_64: W: summary-ended-with-dot C Imports history from origin GG client. kadu-import_history.x86_64: W: spelling-error %description -l en_US Importhistory -> Import history, Import-history, Prehistory kadu-import_history.x86_64: W: no-documentation kadu.src:9: W: setup-not-in-prep kadu.src:17: W: macro-in-comment %files kadu.src:22: W: macro-in-comment %files kadu-devel.x86_64: W: no-documentation kadu.x86_64: W: no-manual-page-for-binary kadu kadu-kadu_completion.x86_64: W: no-documentation kadu-nextinfo.x86_64: W: no-documentation kadu-lednotify.x86_64: W: obsolete-not-provided kadu-led_notify kadu-lednotify.x86_64: W: no-documentation kadu-globalhotkeys.x86_64: W: spelling-error Summary(en_US) hotkeys -> hot keys, hot-keys, hotcakes kadu-globalhotkeys.x86_64: W: spelling-error %description -l en_US hotkeys -> hot keys, hot-keys, hotcakes kadu-globalhotkeys.x86_64: W: no-documentation kadu-anonymous_check.x86_64: W: spelling-error Summary(en_US) lookup -> lockup, hookup, look up kadu-anonymous_check.x86_64: W: spelling-error %description -l en_US lookup -> lockup, hookup, look up kadu-anonymous_check.x86_64: W: no-documentation 15 packages and 0 specfiles checked; 0 errors, 25 warnings. MUST: The package must meet the Packaging Guidelines . Please incorporate Dawid's and my comments. MUST: The License field in the package spec file must match the actual license. Why is -devel package GPLv3+ when main package is GPLv2+? MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use sha256sum for this task as it is used by the sources file once imported into git. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this. $ sha256sum -c SHA256SUM globalhotkeys-0.12-32.tar.gz: OK lednotify-0.12-33.tar.gz: OK messagessplitter-0.12-5.tar.gz: OK networkping-0.12-4.tar.gz: OK nextinfo-0.12-9.tar.gz: OK panelkadu-0.12-10.tar.gz: OK senthistory-0.12-11.tar.gz: OK anonymous_check-0.11.0-1.tar.bz2: OK import_history-0.12.0.tar.bz2: OK kadu-0.12.2.tar.bz2: OK kadu_completion-0.12.0-1.tar.bz2: OK mime_tex-0.12.0-2.tar.bz2: OK $ cat SHA256SUM 3696940aa1a0d9f6ad1576873bc0ab6a4e237cac24c627f0a7284410cdfba72d globalhotkeys-0.12-32.tar.gz 2c7216bfde19beb2aafcbe4868a5a50ae743eaf9046ef9d65d5ba9609ecade7f lednotify-0.12-33.tar.gz ceba4eee8f387fc2c4447886769414db383e1d51039a54ba7afe3c5740c12adf messagessplitter-0.12-5.tar.gz 891ebea7a086f415f2d4f7cdaf8ce1407ae522272b17dd91d99d8a73ce7e7ffc networkping-0.12-4.tar.gz 3a88fb13f334762723e792338c58a0ee42090abec577aa702b5653a3324c0d32 nextinfo-0.12-9.tar.gz 784c2596d9a698b46b8c3a99c96bc556b4370453f57a99aa6a93d9b07d8d5733 panelkadu-0.12-10.tar.gz eb8919dcadf65dcc192ea3de1ad263ef8eff2b080339f5619856dbcb96c60aa0 senthistory-0.12-11.tar.gz 80c4dbf28524b9c1b168982ff6b5ae3254c802fc1661eba8228e12eee0b05408 anonymous_check-0.11.0-1.tar.bz2 f831f97936798ea9ec03334d1ab04fd76506a422d6887addbd92f15b7bd8bc67 import_history-0.12.0.tar.bz2 a1fad5444fedb7af82d64d7e13daa65d3edd553b90efdaef8bf230647d9c1067 kadu-0.12.2.tar.bz2 0c6e361a070c098e0fabdd7a7a893292ffd1e3f373cbce7e9f05a9fc893d0869 kadu_completion-0.12.0-1.tar.bz2 f3f831108a4db4ea1cb7979efdad0d7a6db1b380ef38dade38561e4f8a1b6fa8 mime_tex-0.12.0-2.tar.bz2 MUST: Packages must NOT bundle copies of system libraries. https://fedorahosted.org/fpc/ticket/230 resolution must be followed. MUST: If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present. Are the docs in %{_datadir}/kadu used at runtime? If not, please include them as %doc instead. SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. GPLv3+ plugins don't come with a copy of GPLv3. Please ask upstream(s) to include one with each tarball. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0y5d97hLav&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review