Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=915095 Jamie Nguyen <jamielinux@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+ --- Comment #6 from Jamie Nguyen <jamielinux@xxxxxxxxxxxxxxxxx> --- > I've fixed the tests as you suggest, though it's not > very nice Rather horrible indeed, but I couldn't think of anything better either. > The failures you're seeing aren't exactly failures, > but then lint.js isn't exactly a test suite - it's > more of a coverage test that generates a list of > any attributes that don't have documentation yet. > Possibly we shouldn't run it - it will never fail > (in the exit non-zero sense) anyway. Yeh I think coverage testing is not really the aim of %check so perhaps don't run the lint.js test. Aside from this, everything else looks good so package approved! -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=cqbDsjQMXZ&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review