[Bug 906843] Review Request: rubygem-qpid_proton - Ruby language bindings for the Qpid Proton messaging framework

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=906843

--- Comment #5 from Darryl L. Pierce <dpierce@xxxxxxxxxx> ---
(In reply to comment #4)
> For 0.4-1
> 
> * Version specific requires for ruby(release)
>   - It seems that ruby(release) (Build)Requires should
>     not have version specific dependency
>     (see Vít's comments:
>    
> http://lists.fedoraproject.org/pipermail/ruby-sig/2013-February/001259.html
>     )

Fixed.

> * Installing native extension
>   - The following line
> -------------------------------------------------------
> mkdir -p %{buildroot}%{gem_extdir_mri}/
> mv %{buildroot}%{gem_instdir}/lib/cproton.so \
>    %{buildroot}%{gem_extdir_mri}/lib
> -------------------------------------------------------
>     makes cproton.so _renamed_ to lib (i.e. the
>     file "lib" is created with these lines).

Fixed. The specfile now ensures the directory exists, and then moves the shared
library appropriately.

> * gem install
>   - For gem install, please use %gem_install macro
>     (note that on F-19, %gem_install used different
>      option for documentation generation - on F-18/17,
>      %gem_install also uses --rdoc option)
> 
> Currently "Installing native extension" item is really blocker.

Done.

Updated SPEC:  http://mcpierce.fedorapeople.org/rpms/rubygem-qpid_proton.spec
Updated SRPM: 
http://mcpierce.fedorapeople.org/rpms/rubygem-qpid_proton-0.4-1.1.fc18.src.rpm
Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5070299

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1bIO1cjojQ&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]