Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=915337 --- Comment #4 from Palle Ravn <ravnzon@xxxxxxxxx> --- Package updated Spec URL: http://nmon.zom.dk/nmon.spec SRPM URL: http://nmon.zom.dk/nmon-14g-2.fc18.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=5069343 rpmlint: 3 packages and 1 specfiles checked; 0 errors, 0 warnings. (In reply to comment #3) > -O2 and -Wall are already set in optflags and can therefore be removed. To > do the PPC guys a favor, you could include a conditional clause to add "-D > POWER", if built on PPC. -O2 and -Wall removed. I have added the architecture conditional %ifarch for ppc and ppc64. I am using the %{power64} macro, but not sure if that is more correct than using ppc64? I have tested the build with ppc-koji and the "-D POWER" parameter is invoked for both ppc and ppc64, see http://ppc.koji.fedoraproject.org/koji/taskinfo?taskID=962445. > Make it ...%{name}.1* to allow for changes possible changes in compression. Done. > I think you should use the name macro on the gcc and install invocation. That seems reasonable, done. > The timestamp of Source1 should be preserved. I didn't understand this at first, as the downloaded file had preserved the timestamp from the server. I assume that the timestamp should not change duo to the linebreak fix using sed? That is now corrected with touch, so Source1 is now dated correctly in the /usr/share/doc/... folder. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=JLcpqrcBbp&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review