Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=916508 Pavel Raiskup <praiskup@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |praiskup@xxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |praiskup@xxxxxxxxxx Flags| |fedora-review? --- Comment #1 from Pavel Raiskup <praiskup@xxxxxxxxxx> --- Hi Milan, thanks for packaging npth! I'm interested in review; Here are some notes before I run fedora-review script: 1. There is no %check section - upstream provides two tests in 'make check' phase 2. There is no "usage" documentation. Actually, there is missing manual page for /usr/bin/npth-config . The package 'pth' has pth.3 manual page and also has documentation for 'pth-config' - pth-config.1. At least - As {,n}pth-config scripts have similar options, it would be possible to reuse _very_ easily. 3. README says that nPth is released under LGPLv3+/GPLv2+.. so this should be reflected in License tag. (same way, COPYING.LESSER should be packaged) Pavel -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=sOsqa18AzL&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review