[Bug 909644] Review Request: python-websocket-client - WebSocket client for python

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=909644

--- Comment #5 from Ralph Bean <rbean@xxxxxxxxxx> ---
Thanks Palle.  Yeah, I think you don't get "full rights" to officially review
packages yet.  You must be a member of the "packagers" group in FAS.  However,
the comments are definitely welcome and are a good way to become a
fully-certified packager yourself:

http://fedoraproject.org/wiki/Package_Review_Process#Reviewer

I'll clean up that hardcoded %{distname} you caught in the next release.

Just a thought:  Your sidenote at the bottom is relatively hard to find for
someone just glancing over this BZ issue.  I would place it at the very top
next time so it gives the reader context for your review.

Also, the item from "fedora-review" that produced a Fail (a [!]), I would
collect that and any other failures and also paste them at the top of the
review just so a reader can get the big picture first, before scanning through
all the review items.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2HK26Z61s9&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]