[Bug 915074] Review Request: fedocal - A web based calendar application

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=915074

--- Comment #6 from Pierre-YvesChibon <pingou@xxxxxxxxxxxx> ---
(In reply to comment #5)
> Package Review
> ==============
> 
> Key:
> [x] = Pass
> [!] = Fail
> [-] = Not applicable
> [?] = Not evaluated
> [ ] = Manual review needed
> 
> 
> Issues:
> =======
> - Package contains BR: python2-devel or python3-devel
>   See: http://fedoraproject.org/wiki/Packaging:Python#BuildRequires

Will fix this.

> - Package contains no bundled libraries without FPC exception.
>   Are you bundling flask_fas?

Droping this now.

> - Not required, but can you make the directory ownership in
>   %{python_sitelib} a little more explicit (instead of '*')

Fixed

> - Not required, but can you run the tests in a %check section?

For the moment I'd rather not but I might reconsider this in the future.


New files:
Spec URL: http://pingou.fedorapeople.org/RPMs/fedocal.spec
SRPM URL: http://pingou.fedorapeople.org/RPMs/fedocal-0.1.0-2.fc18.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0etUAsOVaQ&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]