Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=913152 --- Comment #16 from Antonio Trande <trpost@xxxxxxxxxxxx> --- (In reply to comment #15) > You should bump the release for every review request update, > that is, the last one should be Release 4. Yes. > > Things that still should be done include: > > 1. You added > sed -e 's|@@CFLAGS@@|%{optflags}|g' -i Makefile.inc > to the spec as I suggested, but it is pointless, because > SOURCE1 (Makefile.seq.inc) and SOURCE2 (Makefile.par.inc) > still hardcode CFLAGS, that is, you should change those > to the pseudo patch: > -OPTC = -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions > -fstack-protector --param=ssp-buffer-size=4 > +OPTC = -@@CFLAGS@@ > > 2. Following above, the OPTF variable should also use > %{optflags}, and not the hardcoded "-O -Dintel_ -DALLOW_NON_INIT" > that is, should replace the -O with %{optflags}. Done. > > 3. The variable OPTL appears to be the best place to use > -Wl,-as-needed, that is, the pseudo patch: > -OPTL = -O > -OPTL = -Wl,-as-needed Okay but I don't know where impose this flags. > > Long history short, for the sake of review, I would > be satisfied if you do the simpler approach of > dropping the "seq" build, and only do the "par" > build. I agree. I remove 'seq' sub-package building. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=QRsMLEF3bB&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review