Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=915005 --- Comment #2 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- 1. missing BuildReq ... actually, I'm adding those as deps to qt5-qtbase-devel and qt5-qtbase-static, but adding them here in the meantime won't hurt. 2. lots of hidden files in debuginfo (.moc and .rcc), please check that harmless, have bigger things to worry about. :) 3. please replace those ../ cascades with buildroot/bindir, it's not very readable I'd rather not, relative links are much nicer than absolute ones for various reasons. 4. macro in comment again, this one's mostly harmless, and valid as-is imho. (%configure and ones like it are the ones to worry about). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=r6rrEwICBJ&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review