Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: iwlwifi-firmware - Microcode for Intel® PRO/Wireless 3945 A/B/G network adaptors https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230096 ------- Additional Comments From matthias@xxxxxxxxxxxx 2007-02-27 04:54 EST ------- Xavier : Being pedantic isn't always the best thing. You use the word "must" in many places, some of which should be "should" instead, and others more importantly, where you are plain wrong. For instance "you must use a %{?dist} tag" is incorrect, and in this case, it's _deliberate_ to not use one, since it allows hardlinking the package across multiple releases. Your only valid comment is the one about the %changelog, but please realize that it's pretty much useless to have multiple entries for the same day, especially if they're so minor. The wrong thing would have been not to increment the release. Packaging rules and guidelines are something really useful, but nothing will ever beat using common sense as much as possible. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review