Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Chmsee - a GTK2 CHM viewer based on chmlib and gecko https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229826 ------- Additional Comments From pertusus@xxxxxxx 2007-02-27 04:26 EST ------- (In reply to comment #21) > The build log if enabled %{?_smp_flags} This is not for the fedora package but for upstream. There is no problem for us to disable smp_mflags. However I had a look, and a possibility is that chmsee_LDFLAGS is used incorrectly to specify library link, it should only be for linker options, chmsee_LDADD is for link. So in my opinion, it should be along: chmsee_LDFLAGS = -R$(GECKO_HOME) \ $(AM_LDFLAGS) chmsee_LDADD = \ libcppwrapper.la \ @CHMSEE_LIBS@ \ @CHMLIB_LIBS@ \ @MD5_LIBS@ \ $(GECKO_LIBS) \ $(GECKO_EXTRA_LIBS) It may also be another issue. I have spotted 2 other problems, still for upstream: * $(addprefix is not portable * in the GLIB_GENMARSHAL rules, the files shouldn't be created in $(srcdir), $(srcdir) could be read-only. > icon scriptlet updated. Still missing in %postun Also I think the use of the gnochm icon for mimetype deserves a comment. It is in changelog, but it seems to me that a comment near the Source1 or near the install calls in %install should be there too. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review