Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910485 nucleo <alekcejk@xxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |alekcejk@xxxxxxxxxxxxxx Flags| |fedora-review? --- Comment #2 from nucleo <alekcejk@xxxxxxxxxxxxxx> --- To distinguish kajongg and kmahjongg maybe better summary will be "Classical Mah Jongg game for four players" from README. All files GPLv2+ but modeltest.py GPLv2, README say "Kajongg is covered by the GNU GPL2 license - see COPYING." Documentation under GFDL license, so License: GPLv2 and GFDL License files COPYING.DOC, voices/female2/COPYRIGHT should be added in %doc and README. rpmlint output: $ rpmlint kajongg-4.10.0-2.fc18.noarch.rpm kajongg-4.10.0-2.fc18.src.rpm kajongg.spec kajongg.noarch: W: spelling-error Summary(en_US) Mah -> Maj, Ah, Mach kajongg.noarch: E: non-executable-script /usr/share/kde4/apps/kajongg/deferredutil.py 0644L /usr/bin/env kajongg.noarch: E: non-executable-script /usr/share/kde4/apps/kajongg/server.py 0644L /usr/bin/env kajongg.noarch: W: no-manual-page-for-binary kajongg kajongg.noarch: W: no-manual-page-for-binary kajonggserver kajongg.src: W: spelling-error Summary(en_US) Mah -> Maj, Ah, Mach kajongg.src:77: W: macro-in-comment %{name} kajongg.spec:77: W: macro-in-comment %{name} 2 packages and 1 specfiles checked; 2 errors, 6 warnings. All commented lines should be removed including #update-desktop-database because no MimeType key in kajongg.desktop. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lzB2Y9tBtI&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review