[Bug 913152] Review Request: MUMPS - A MUltifrontal Massively Parallel sparse direct Solver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=913152

--- Comment #10 from Paulo Andrade <paulo.cesar.pereira.de.andrade@xxxxxxxxx> ---
(In reply to comment #9)
> At this point, I'm blocked by my knowledges which are limited in this field.
> You think I had to study for a long time how Makefile.inc are used during
> compilation and probably it would have not been so difficult for an expert
> programmer.

  I think you should focus first on getting the examples
to show something more helpful :-) The error messages
 ERROR in MPI_ALLREDUCE, DATATYPE=           7
are not much encouraging.

> About command line flags, I've not idea why he who has written the patches
> then has arranged those flags in that way. :)

  Usually this is not much of an issue, and it it only
a rpmlint warning.

  There is a small chance of problems if one intends
to run debian binaries in fedora if changing the soname
to match the package version, so, probably better to
not let it be the cause of incompatibility.

> How would you write that line ?

  I would experiment a bit, no ready response, but I
would at first move the -Wl,-z,defs earlier in the
command line, and ensure any -L and -l are before
object file names, and also add -Wl,-as-needed.

  BTW, you should not hardcode CFLAGS in the SOURCEX
Makefile.*, and instead patch them. Could add a regex
pattern there like @@CFLAGS@@, and in the spec run
sed -e 's|@@CFLAGS@@|%{optflags}|g' -i Makefile.*

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=et5CwDqR56&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]