Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: vixie-cron https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226529 ------- Additional Comments From pertusus@xxxxxxx 2007-02-26 18:27 EST ------- >From a quick glance at the specfile, I have noticed the following issues: * Prereq should be changed to the appropriate Requires(...) * You should use $RPM_SOURCE_DIR or %SOURCEN, but not both. I suggest using %SOURCEN, since it is most common. * rpm macros should be used more. * timestamp of data files should be kept with -p * /etc/pam.d/crond is certainly %config(noreplace) Suggestion: In my opinion, /etc/rc.d/init.d/crond shouldn't be marked as %config. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review