Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=785312 --- Comment #2 from Mark McKinstry <mmckinst@xxxxxxxxxxx> --- Jos, > Mark, if you know more > examples that have been accepted into Fedora, some pointers might be > helpfull in the review process. I haven't found any yet. > The "statically-linked-binary" error and "missing-PT_GNU_STACK-section" > error may be normal for assembly based executables, but I have no experience > on this so cannot judge this. References to other similar cases may be > usefull here. The statically-linked-binary error is normal. Debian has an exception for e3 in its rpmlint equivalent for that error: http://lintian.debian.org/tags/statically-linked-binary.html The missing-PT_GNU_STACK-section is not normal. After debugging it some more, I figured the problem out. If I added the fix from http://www.gentoo.org/proj/en/hardened/gnu-stack.xml#doc_chap6 ,it fixed the problem on 64 bit, but not 32 bit. After looking over the makefile and the code I found he was using the guide at http://www.muppetlabs.com/~breadbox/software/tiny/teensy.html to make a tiny ELF on 32 bit linux. Luckily you can build it the normal way to include the GNU stack stuff which is what the makefile patch I added does. > The empty debug rpm should probably be disabled. See the remarks here: > https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/ > Guidelines#Debuginfo_packages Fixed. > The BuildRoot is not used by the Fedora rpmbuild and will be ignored. See: > https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/ > Guidelines#BuildRoot_tag > so it should probably be removed. I intend to include the package in EPEL 5 which requires the buildroot. With the new spec and src.rpm, rpmlint should be happy, only complaining about the statically-linked-binary which is to be expected. SPEC: http://mmckinst.fedorapeople.org/packages/e3/e3.spec SRPM: http://mmckinst.fedorapeople.org/packages/e3/e3-2.8-3.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4NokvyQq04&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review