[Bug 910565] Review Request: python-github - A Python library implementing the full Github API v3.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=910565

Richard Marko <rmarko@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |
              Flags|                            |fedora-review+

--- Comment #6 from Richard Marko <rmarko@xxxxxxxxxx> ---
(In reply to comment #5)
> Fixed version according to c#3 && c#4
> 
> http://jmoskovc.fedorapeople.org/python-github.spec
> http://jmoskovc.fedorapeople.org/python-github-1.11.1-2.fc18.src.rpm

* Package name correct
* Packaging latest version
* License ok and good for fedora
* SPEC file clean and legible
* Builds fine in mock
* Sane filelist
* Sane reqs/provs

=> Package approved.

Few minor issue that should be fixed:

[!]: Package contains BR: python2-devel or python3-devel
See: http://fedoraproject.org/wiki/Packaging:Python#BuildRequires

%install: rm -rf %{buildroot} present but not required
%clean: rm -rf %{buildroot} present but not required

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4QrDXLNcwK&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]