Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Chmsee - a GTK2 CHM viewer based on chmlib and gecko https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229826 ------- Additional Comments From pertusus@xxxxxxx 2007-02-26 17:30 EST ------- (In reply to comment #19) > > done. This icon is better than nothing because it is just a question mark and a > CHM doc.. The question mark looks like "I know nothing" instead of "help docs". > And chm is not only for help docs, this is why chmsee-icon.png looks like a book > (though more like a dictionary) A question mark is not necessarily "I know nothing", it may also mean "I have a question". > (In reply to comment #18) > > Why isn't %{?_smp_mflags} used? > > linking problems, don't know how to fix :( Please put a comment saying something along # %%{?_smp_mflags} breaks build. Linking problems? > > Spec URL: ftp://ftp.fedora.cn/pub/fedora-cn/in-review/chmsee.spec > SRPM URL: ftp://ftp.fedora.cn/pub/fedora-cn/in-review/chmsee-1.0.0-0.8.beta.src.rpm Another issue is that now that there is something installed in the gnome theme, you should add the gtk-update-icon-cache scriptlet for that theme too (in addition to the one for the hicolor theme). The source doesn't seems to match upstream: b18df276ff8050668ff3da163efe147c chmsee-1.0.0-beta.tar.gz 8ebce73126d94cc646565f38aa94dcc9 ../SOURCES/chmsee-1.0.0-beta.tar.gz Seems like upstream did a new release without changing the tarball name... -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review