[Bug 912878] Review Request: profile-sync-daemon - psd

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=912878

--- Comment #3 from graysky@xxxxxxxxxxxx ---
(In reply to comment #2)
> You probably shouldn't copy upstream changelog to %changelog, it's simply a
> changelog of the spec/SRPM.
> 
> * Tue Feb 19 2013 graysky <graysky@xxxxxxxxxxxx> - 5.24-1
> - New release 5.24
> 
> Should be fine.
> 
> On the other hand, be sure to add the CHANGELOG and README.md to %doc. Once
> approved, don't forget to update the Fedora package information in
> README.md, so the offical package doesn't point users to the unofficial (by
> official, I mean in Fedora repos).

Took your suggestions with one exception: should I really include the github
README.md in the package?

Files:
http://repo-ck.com/fedora_rpms/profile-sync-daemon.spec
http://repo-ck.com/fedora_rpms/profile-sync-daemon-5.24-2.fc18.src.rpm
http://repo-ck.com/fedora_rpms/profile-sync-daemon-5.24-2.fc18.noarch.rpm

Koji build log:
http://koji.fedoraproject.org/koji/taskinfo?taskID=5038248

> Why there is a Makefile.fedora18 file, when you use Makefile.archlinux? They
> are identical, but anyway, doesn't make much sense to me.

Ah, my bad.  Fixed in 5.24-2 available at the URL above.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vgVfcy084j&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]