Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: sdcc - Small Device C Compiler https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226795 j.w.r.degoede@xxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |j.w.r.degoede@xxxxxx Flag| |fedora-review? ------- Additional Comments From j.w.r.degoede@xxxxxx 2007-02-26 16:01 EST ------- MUST: ===== 0 rpmlint output is: W: sdcc rpm-buildroot-usage %prep sed -e 's,find $RPM_BUILD_ROOT,find $RPM_BUIL W: sdcc devel-file-in-non-devel-package /usr/share/sdcc/lib/src/pic/libsdcc/uin W: sdcc devel-file-in-non-devel-package /usr/share/sdcc/lib/src/pic16/libc/ctyp W: sdcc devel-file-in-non-devel-package /usr/share/sdcc/lib/src/pic/libm/floorf W: sdcc devel-file-in-non-devel-package /usr/share/sdcc/lib/src/pic16/libc/stdl <many many more like these> * Package and spec file named appropriately 0 Packaged according to packaging guidelines * License ok * spec file is legible and in Am. English. * Source matches upstream * Compiles and builds on devel x86_64 * BR: ok * No locales * No shared libraries * Not relocatable 0 Package owns / or requires all dirs * No duplicate files & Permissions ok * %clean & macro usage OK * Contains code only * %doc does not affect runtime, and isn't large enough to warrent a sub package * no -devel package needed, no libs / .la files. * no .desktop file required MUST fix: ========= * put all the files under /usr/share/sdcc/lib/src and the .asm files under /usr/share/sdcc/lib/* in a seprate -src subpackage. AFAIK these files are only needed when one wants to look at the innerworkings of the C-library and are not needed for normal development, thus they shouldn't be part of the base package. * Remove the "Requires: gc" from the specfile, gc is a lib and an automatic dependency on the needed .so file will be generated. * We all agree a -devel package is bogus so remove the devel subpackage instead of just commenting it * sdcc's make install installs the docs under /usr/share/sdcc/doc, they should be installed under /usr/share/doc/sdcc-%{version} using %doc Tip: after the "make install" do: mv $RPM_BUILD_ROOT%{_datadir}/%{name}/doc installed-docs and then to %files add "%doc installed-docs/*" * You must own the sdcc dirs the package create, under %files don't write: %{_libexecdir}/sdcc/* %{_datadir}/sdcc/* But write: %{_libexecdir}/%{name} %{_datadir}/%{name} Then the package will also own the %{_datadir}/sdcc and %{_libexecdir}/sdcc dirs * You must also own %{_datadir}/emacs as that is not a standard dir, easiest way todo this is to just write %{_datadir}/emacs under %files instead of %{_datadir}/emacs/site-lisp/* -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review