[Bug 912477] Review Request: perl-Filesys-SmbClient - Samba client Perl module

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=912477

--- Comment #3 from Petr Šabata <psabata@xxxxxxxxxx> ---
The license address is not a blocker.

Since your package doesn't run the tests (for stated reasons), you can remove
most of your BRs, keeping just perl(ExtUtils::MakeMaker) and
perl(ExtUtils::MakeMaker).

> 54 perl Makefile.PL INSTALLDIRS=vendor CCFLAGS='-DHAVE_CLOSEFN'

This is an arch-dependent module, add OPTIMIZE="%{optflags}" here.


The rest of the package looks good.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=i7e3TjwEF8&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]