Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=886908 Simone Caronni <negativo17@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+ --- Comment #9 from Simone Caronni <negativo17@xxxxxxxxx> --- (In reply to comment #8) > Fixed the above, except for the Source0 line, which won't work as %{name}, > since it's xonotic-data, not xonotic, and the tarball is xonotic. Yep, you're right, but since you're regenerating the tarball, I think you could use "xonotic-data-%{version}.tar.gz" before committing; so people using the old buildroot (i.e. all sources in the same folder) will easily spot it and is more consistent. Package approved. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9ozHCXbzPI&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review