Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904330 --- Comment #4 from Petr Šabata <psabata@xxxxxxxxxx> --- Ok, here are some notes from me :) > 23 %description > 24 This module collects ip validation routines to make input validation, and > 25 untainting easier and more readable. > 26 > 27 All functions return an untainted value if the test passes, and undef if it > 28 fails. This means that you should always check for a defined status explicitly. > 29 Don't assume the return will be true. (e.g. is_username('0')) > 30 > 31 The value to test is always the first (and often only) argument. I'd keep only the first sentence (lines 24-25), the rest is too technical for a description. Also, substitute "ip" with "IP address". > 36 find lib -name "*.pm" -exec chmod -c a-x {} + Not needed here. Could be removed. > 2 Version: 0.14 A new version, 0.18, came out yesterday. Please, update the package. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=tzU1Fkpv13&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review