Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910565 Toshio Ernie Kuratomi <a.badger@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |a.badger@xxxxxxxxx --- Comment #4 from Toshio Ernie Kuratomi <a.badger@xxxxxxxxx> --- I started packaging this last night before finding this. Some comments from that attempt: * Package appears to be LGPLv3+, not GPLv2+ (see the comment headers of the source files, for instance GitObject.py) * License files and other docs are in the github directory and should be moved out to %doc. As Richard Marko points out, you can do this with mv. But there's more than just the github/doc directory: COPYING, COPYING.LESSER, and ReadMe.md * Need to run the tests during the build: %check %{__python} setup.py test * Should exclude the tests from the binary package (I grepped for tests and import in the source to determine that they weren't needed at runtime): %files [...] %exclude %{python_sitelib}/github/tests -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=hcdz5fer3Z&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review