Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=868578 --- Comment #11 from Denis Arnaud <denis.arnaud_fedora@xxxxxxx> --- Spec URL: http://denisarnaud.fedorapeople.org/re2/re2.spec SRPM URL: http://denisarnaud.fedorapeople.org/re2/re2-20130115-2.fc18.src.rpm ============================================== (In reply to comment #8) > Now for the actual review... > > [!]: Requires correct, justified where necessary. > => Drop the "Requires: pkgconfig" from the devel subpackage, it doesn't > provide any pkgconfig file. Done > [!]: Rpmlint is run on all rpms the build produces. > => There are a few "undefined-non-weak-symbol" warnings, which should be > fixed. (try "ldd -d -r /usr/lib64/libre2.so.0.0.0" for more details) > Adding "-pthread" to the CXXFLAGS seems to be enough. However, if this > flags really is necessary, I would strongly suggest you submit a patch > upstream so that it gets added to the RE2_CXXFLAGS in the Makefile (as > these seem to be the minimum flags which shouldn't be overwritten) > => The rest of the warnings can be safely ignored. Done. It has been suggested upstream to have an additional RE2_LDFLAGS variable in the Makefile (http://code.google.com/p/re2/source/browse/Makefile): http://groups.google.com/forum/?fromgroups=#!topic/re2-dev/bkUDtO5l6Lo > [!]: Packages should try to preserve timestamps of original installed files. > => Try passing the INSTALL="install -p" variable to the make install > command. Done ================= Ready for the final review/approval :) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=yRDhd9HPQB&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review