Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=909485 Michael Scherer <misc@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misc@xxxxxxxx --- Comment #1 from Michael Scherer <misc@xxxxxxxx> --- Hi, a few note : - BuildRoot is no longer needed since a few rpm version, so consider dropping it - same for %defattr(-,root,root,-) ( default in rpm since a few rpm version ) - and the rm -rf $RPM_BUILD_ROOT in %install ( again, rpm do clean by default now ) - policy requires a comment on how the tarball was generate if there is no download area, and since the url is a git repository, we need the command. https://fedoraproject.org/wiki/Packaging:SourceURL#Using_Revision_Control - I think this is better to have a requires on package rather than on file, because requires on file make people download a 2nd index ( ie, the file index ) which is a pain over a slow link ( even if the policy say this is not downloaded for files in /bin, My experience say the contrary, but I need to check ). Consider replace /usr/bin/getopt by "util-linux". See https://fedoraproject.org/wiki/Packaging:Guidelines#File_Dependencies - since there is multiple license, could you explain the breakdown : https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Multiple_Licensing_Scenarios -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Gasd42LjM1&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review