Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910793 --- Comment #12 from Eduardo Echeverria <echevemaster@xxxxxxxxx> --- (In reply to comment #11) > Believe me, I very much want to kill the client-side bundled JS exception. > I hope to make it a Feature by F21 or so. > > Unfortunately, without clear JavaScript guidelines, packages trying to split > them off now will inevitably go about it different ways, and that'll create > more work for the people trying to unbundle everything properly later with > clear guidelines in place. Instead of just dealing with one legacy of > bundling everything, we'll have to deal with several other legacy unbundling > methods. T.C. Well, don't dwell on this for now. ;) Let us then over the package - Jeremy, the package include a configuration file for Apache, however, i don't see a proper Requires for it, Why? I guess that the package would work well without a web server, but installs files in /etc/httpd/conf.d Let us see the ownership of the directory: $ rpm -qf /etc/httpd/conf.d/ httpd-2.4.3-12.fc18.x86_64 spice-html5 places files into /etc/httpd/conf.d/ spice-html5 depends on httpd to function normally, and would Require: httpd - cleaning of buildroot in %install is not needed - %defattr is not needed at least that you have intentions to ship this package to el5, see http://fedoraproject.org/wiki/EPEL/GuidelinesAndPolicies#EL5. But if you ask me, I am among those who think that we should move to el6 directly. This is obviously your decision :) - Please include COPYING.LESSER on %doc - Please correct the tag license - In %Source0, use the appropriate macros Source0: http://www.spice-space.org/download/spice-html5/spice-html5-0.1.0.tar.gz should be Source0: http://www.spice-space.org/download/spice-html5/%{name}-%{version}.tar.gz This is beneficial for the packager because it saves work to upgrade the package -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4WQuX4Qzgf&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review