Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910511 nucleo <alekcejk@xxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+ --- Comment #3 from nucleo <alekcejk@xxxxxxxxxxxxxx> --- Also COPYING.DOC needs to be added and notices for parts under different licenses. But everything else is fine. MUST Items: + rpmlint output $ rpmlint knavalbattle-4.10.0-1.fc18.i686.rpm knavalbattle-debuginfo-4.10.0-1.fc18.i686.rpm knavalbattle-4.10.0-2.fc18.src.rpm knavalbattle.spec knavalbattle.i686: W: no-manual-page-for-binary kbattleship 3 packages and 1 specfiles checked; 0 errors, 1 warnings. + named and versioned according to the Package Naming Guidelines. Package name match the upstream tarball name knavalbattle-4.10.0.tar.xz + spec file name knavalbattle.spec matches base package name + complies with all the legal guidelines: + License: GPLv2+ and GFDL, matches actual license + No known patent problems + No emulator, no firmware, no binary-only or prebuilt components + COPYING (GNU GENERAL PUBLIC LICENSE Version 2), COPYING.DOC (GNU Free Documentation License Version 1.2) packaged as %doc + source matches upstream: MD5: 7fc88b443a62cbbda40e42ef6aa9359e knavalbattle-4.10.0.tar.xz SHA1: a52486a7f3109633ce340981c6c1706312b69606 knavalbattle-4.10.0.tar.xz SHA256: 45850f6420ff62affd105e827beccc1ae5dbee84b398dd1f851af75b6aff13b1 knavalbattle-4.10.0.tar.xz + builds on at least one arch build from mock is in F18 kde-unstable repo + no known non-working arches, so no ExcludeArch needed + no missing BuildRequires (builds in mock) + locales are handled properly by using %find_lang kbattleship --with-kde + ldconfig call not needed (no shared libraries) + no duplicated system libraries + package not relocatable (no Prefix tag) + directory ownership correct (doesn't own directories owned by another package, owns all package-specific directories %{_kde4_appsdir}/kbattleship/) + no duplicate files in %files + permissions correct, %defattr(-,root,root,-) not needed now, executables have executable permissions + macros used where possible (%{name}, %{version}, %{buildroot}, %{_target_platform}, %{cmake_kde4}, %{_kde4_datadir}, %{_kde4_bindir}, %{_kde4_iconsdir},%{_kde4_appsdir} ) + non-code content: only permitted content, data files under license that matches the code + no large documentation files, so no -doc package needed + no %doc files required at runtime + no header files, no -devel package needed + no static libraries, so no -static package needed + no devel symlinks which would need to be in a -devel subpackage + devel packages must require the base package (no -devel package) + no .la files + kbattleship.desktop file for the GUI app kbattleship present + desktop-file-validate is used in %check and the kbattleship.desktop file passes validation + all filenames are valid UTF-8 + other packaging guidelines: + complies with the Filesystem Hierarchy Standard (all files in %{_kde4_datadir}, %{_kde4_bindir}, %{_kde4_iconsdir},%{_kde4_appsdir}) + proper changelog, tags, BuildRequires, Summary, Description (got from knavalbattle's documentation) + no non-UTF-8 characters + all relevant documentation included as %doc (COPYING, COPYING.DOC, AUTHORS) + RPM_OPT_FLAGS are used in %{cmake_kde4} macro + debuginfo package is valid (contains stripped symbols from ELF binary and source code related to it) + no rpaths (no check-rpaths error) + no configuration files, so %config guideline doesn't apply + no init scripts, so init script guideline doesn't apply + timestamps are preserved + %{?_smp_mflags} used + not a web application, so web application guideline doesn't apply + no conflicts (kdegames-4.10.0 is metapackage now which not includes apps) SHOULD Items: + license already included upstream + no translations for description and summary provided by upstream + package builds in mock (built for kde-unstable) - successfully tested the package functionality (no testing yet) + scriptlets are sane (updating icon chache in %post, %postun, %posttrans) + subpackages other than devel should require the base package using a fully versioned dependency (no subpackages) + no .pc files, so "placement of .pc files" is irrelevant + no file dependencies - package should contain man pages for binaries/scripts APPROVED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=EJLVijyDhu&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review